[PATCH] D66055: [X86] Support -mlong-double-80

[Leonard Chan via Phabricator via llvm-commits]

leonardchan added a comment.

I believe this patch is causing 2 test failures on our x64 clang bots:

  -- Testing: 15385 tests, 32 threads --
  Testing: 0 .. 10.. 20.. 30
  FAIL: Clang :: Driver/mlong-double-128.c (5227 of 15385)
  ******************** TEST 'Clang :: Driver/mlong-double-128.c' FAILED ********************
  Script:
  --
  : 'RUN: at line 1';   /b/s/w/ir/k/recipe_cleanup/clangi0KG9E/llvm_build_dir/bin/clang -target powerpc-linux-musl -c -### /b/s/w/ir/k/llvm-project/clang/test/Driver/mlong-double-128.c -mlong-double-128 2>&1 | /b/s/w/ir/k/recipe_cleanup/clangi0KG9E/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/clang/test/Driver/mlong-double-128.c
  : 'RUN: at line 2';   /b/s/w/ir/k/recipe_cleanup/clangi0KG9E/llvm_build_dir/bin/clang -target powerpc64-pc-freebsd12 -c -### /b/s/w/ir/k/llvm-project/clang/test/Driver/mlong-double-128.c -mlong-double-128 2>&1 | /b/s/w/ir/k/recipe_cleanup/clangi0KG9E/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/clang/test/Driver/mlong-double-128.c
  : 'RUN: at line 3';   /b/s/w/ir/k/recipe_cleanup/clangi0KG9E/llvm_build_dir/bin/clang -target powerpc64le-linux-musl -c -### /b/s/w/ir/k/llvm-project/clang/test/Driver/mlong-double-128.c -mlong-double-128 2>&1 | /b/s/w/ir/k/recipe_cleanup/clangi0KG9E/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/clang/test/Driver/mlong-double-128.c
  : 'RUN: at line 4';   /b/s/w/ir/k/recipe_cleanup/clangi0KG9E/llvm_build_dir/bin/clang -target i686-linux-gnu -c -### /b/s/w/ir/k/llvm-project/clang/test/Driver/mlong-double-128.c -mlong-double-128 2>&1 | /b/s/w/ir/k/recipe_cleanup/clangi0KG9E/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/clang/test/Driver/mlong-double-128.c
  : 'RUN: at line 6';   /b/s/w/ir/k/recipe_cleanup/clangi0KG9E/llvm_build_dir/bin/clang -target x86_64-linux-musl -c -### /b/s/w/ir/k/llvm-project/clang/test/Driver/mlong-double-128.c -mlong-double-128 -mlong-double-80 2>&1 | /b/s/w/ir/k/recipe_cleanup/clangi0KG9E/llvm_build_dir/bin/FileCheck --implicit-check-not=-mlong-double- /dev/null
  : 'RUN: at line 7';   /b/s/w/ir/k/recipe_cleanup/clangi0KG9E/llvm_build_dir/bin/clang -target x86_64-linux-musl -c -### /b/s/w/ir/k/llvm-project/clang/test/Driver/mlong-double-128.c -mlong-double-80 -mlong-double-128 2>&1 | /b/s/w/ir/k/recipe_cleanup/clangi0KG9E/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/clang/test/Driver/mlong-double-128.c
  : 'RUN: at line 11';   /b/s/w/ir/k/recipe_cleanup/clangi0KG9E/llvm_build_dir/bin/clang -target aarch64 -c -### /b/s/w/ir/k/llvm-project/clang/test/Driver/mlong-double-128.c -mlong-double-128 2>&1 | /b/s/w/ir/k/recipe_cleanup/clangi0KG9E/llvm_build_dir/bin/FileCheck --check-prefix=ERR /b/s/w/ir/k/llvm-project/clang/test/Driver/mlong-double-128.c
  : 'RUN: at line 12';   /b/s/w/ir/k/recipe_cleanup/clangi0KG9E/llvm_build_dir/bin/clang -target powerpc -c -### /b/s/w/ir/k/llvm-project/clang/test/Driver/mlong-double-128.c -mlong-double-80 2>&1 | /b/s/w/ir/k/recipe_cleanup/clangi0KG9E/llvm_build_dir/bin/FileCheck --check-prefix=ERR2 /b/s/w/ir/k/llvm-project/clang/test/Driver/mlong-double-128.c
  --
  Exit Code: 1
  
  Command Output (stderr):
  --
  /b/s/w/ir/k/llvm-project/clang/test/Driver/mlong-double-128.c:9:11: error: CHECK: expected string not found in input
  // CHECK: "-mlong-double-128"
            ^
  <stdin>:1:1: note: scanning from here
  Fuchsia clang version 10.0.0 (https://fuchsia.googlesource.com/a/third_party/llvm-project 87869b398dbe525658d5ccfe2e9edd2cdf342662) (based on LLVM 10.0.0svn)
  ^
  <stdin>:5:37: note: possible intended match here
  clang-10: error: unsupported option '-mlong-double-128' for target 'powerpc64-pc-freebsd12'
                                      ^
  
  --
  
  ********************
  Testing: 0 .. 10.. 20.. 30
  FAIL: Clang :: Driver/mlong-double-64.c (5230 of 15385)
  ******************** TEST 'Clang :: Driver/mlong-double-64.c' FAILED ********************
  Script:
  --
  : 'RUN: at line 1';   /b/s/w/ir/k/recipe_cleanup/clangi0KG9E/llvm_build_dir/bin/clang -target powerpc-linux-musl -c -### /b/s/w/ir/k/llvm-project/clang/test/Driver/mlong-double-64.c -mlong-double-64 2>&1 | /b/s/w/ir/k/recipe_cleanup/clangi0KG9E/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/clang/test/Driver/mlong-double-64.c
  : 'RUN: at line 2';   /b/s/w/ir/k/recipe_cleanup/clangi0KG9E/llvm_build_dir/bin/clang -target powerpc64-pc-freebsd12 -c -### /b/s/w/ir/k/llvm-project/clang/test/Driver/mlong-double-64.c -mlong-double-64 2>&1 | /b/s/w/ir/k/recipe_cleanup/clangi0KG9E/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/clang/test/Driver/mlong-double-64.c
  : 'RUN: at line 3';   /b/s/w/ir/k/recipe_cleanup/clangi0KG9E/llvm_build_dir/bin/clang -target powerpc64le-linux-musl -c -### /b/s/w/ir/k/llvm-project/clang/test/Driver/mlong-double-64.c -mlong-double-64 2>&1 | /b/s/w/ir/k/recipe_cleanup/clangi0KG9E/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/clang/test/Driver/mlong-double-64.c
  : 'RUN: at line 4';   /b/s/w/ir/k/recipe_cleanup/clangi0KG9E/llvm_build_dir/bin/clang -target i686-linux-gnu -c -### /b/s/w/ir/k/llvm-project/clang/test/Driver/mlong-double-64.c -mlong-double-64 2>&1 | /b/s/w/ir/k/recipe_cleanup/clangi0KG9E/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/clang/test/Driver/mlong-double-64.c
  : 'RUN: at line 5';   /b/s/w/ir/k/recipe_cleanup/clangi0KG9E/llvm_build_dir/bin/clang -target x86_64-linux-musl -c -### /b/s/w/ir/k/llvm-project/clang/test/Driver/mlong-double-64.c -mlong-double-64 2>&1 | /b/s/w/ir/k/recipe_cleanup/clangi0KG9E/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/clang/test/Driver/mlong-double-64.c
  : 'RUN: at line 9';   /b/s/w/ir/k/recipe_cleanup/clangi0KG9E/llvm_build_dir/bin/clang -target aarch64 -c -### /b/s/w/ir/k/llvm-project/clang/test/Driver/mlong-double-64.c -mlong-double-64 2>&1 | /b/s/w/ir/k/recipe_cleanup/clangi0KG9E/llvm_build_dir/bin/FileCheck --check-prefix=ERR /b/s/w/ir/k/llvm-project/clang/test/Driver/mlong-double-64.c
  --
  Exit Code: 1
  
  Command Output (stderr):
  --
  /b/s/w/ir/k/llvm-project/clang/test/Driver/mlong-double-64.c:7:11: error: CHECK: expected string not found in input
  // CHECK: "-mlong-double-64"
            ^
  <stdin>:1:1: note: scanning from here
  Fuchsia clang version 10.0.0 (https://fuchsia.googlesource.com/a/third_party/llvm-project 87869b398dbe525658d5ccfe2e9edd2cdf342662) (based on LLVM 10.0.0svn)
  ^
  <stdin>:5:37: note: possible intended match here
  clang-10: error: unsupported option '-mlong-double-64' for target 'powerpc64-pc-freebsd12'
                                      ^
  
  --
  
  ********************
  Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
  Testing Time: 78.20s
  ********************
  Failing Tests (2):
      Clang :: Driver/mlong-double-128.c
      Clang :: Driver/mlong-double-64.c

Could you look into this? Thanks.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66055/new/

https://reviews.llvm.org/D66055