[PATCH] D66354: Add LLDB dataformatters for llvm::StringRef and lldb_private::ConstString

[Adrian Prantl via llvm-commits]

I'm not trying to argue against it, but at least our green dragon bots build LLDB without debug info so such a test would easily regress itself, even if the feature doesn't.

-- adrian

> On Aug 16, 2019, at 3:36 PM, Jim Ingham <jingham at apple.com> wrote:
> 
> Maybe we should have a section of the testsuite that gets run when lldb is built with debug information?  Then you could just run lldb on itself, stop anywhere, use the expression parser to make a variable of the type in question, and see that it prints properly.
> 
> Jim
> 
> 
>> On Aug 16, 2019, at 3:31 PM, Adrian Prantl via Phabricator <reviews at reviews.llvm.org> wrote:
>> 
>> aprantl added a comment.
>> 
>> It's not quite obvious to me how to write a test for this. The test would need to live in LLDB, and it would need to compile a program linking against a variant of libSupport that was compiled with debug info. I'm not sure how to best do this.
>> 
>> 
>> Repository:
>> rG LLVM Github Monorepo
>> 
>> CHANGES SINCE LAST ACTION
>> https://reviews.llvm.org/D66354/new/
>> 
>> https://reviews.llvm.org/D66354
>> 
>> 
>> 
>