[PATCH] D66356: [WebAssembly] Forbid use of EM_ASM with setjmp/longjmp

[Alon Zakai via Phabricator via llvm-commits]

kripken accepted this revision.
kripken added a comment.
This revision is now accepted and ready to land.

lgtm module the error message, let's find the best phrasing there.



================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyLowerEmscriptenEHSjLj.cpp:1004
+      if (isEmAsmCall(M, Callee))
+        report_fatal_error("Cannot use EM_ASM* with setjmp/longjmp in " +
+                               F.getName() + ". Please consider using EM_JS.",
----------------
How about "alongside" instead of "with", to hint that the issue is using both in the same function?

And/or maybe replace the final "." with ", or refactor the EM_ASM to another function"?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66356/new/

https://reviews.llvm.org/D66356