[PATCH] D66190: [CodeGen] Add a pass to do block predication on SSA machine IR

[James Molloy via Phabricator via llvm-commits]

jmolloy accepted this revision.
jmolloy added a comment.
This revision is now accepted and ready to land.

Hi Thomas,

Thanks for this! one comment but overall LGTM.

James



================
Comment at: llvm/lib/CodeGen/EarlyIfConversion.cpp:982
+/// Update the dominator tree after if-conversion erased some blocks.
+void EarlyIfPredicator::updateDomTree(ArrayRef<MachineBasicBlock *> Removed) {
+  // convertIf can remove TBB, FBB, and Tail can be merged into Head.
----------------
This looks stateless with respect to DomTree and Removed; we should share this between the two implementations.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66190/new/

https://reviews.llvm.org/D66190