[PATCH] D65614: [Reassociate] Stop linearizing all associative expression trees w/o profitability

[Mandeep Singh Grang via Phabricator via llvm-commits]

mgrang added inline comments.


================
Comment at: lib/Transforms/Scalar/GVN.cpp:293
+    }
+    std::sort(e.varargs.begin(), e.varargs.end());
+  } else {
----------------
Please use range based llvm::sort instead of std::sort. See https://llvm.org/docs/CodingStandards.html#beware-of-non-deterministic-sorting-order-of-equal-elements


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65614/new/

https://reviews.llvm.org/D65614