[PATCH] D66259: Migrate llvm::make_unique to std::make_unique

Jonathan Wakely via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 15 10:17:29 PDT 2019


jwakely added a comment.

In D66259#1631586 <https://reviews.llvm.org/D66259#1631586>, @thakis wrote:

> It looks like this breaks building with gcc5.1:


Why are you using 5.1? That's dumb. There are tons of bugs in 5.1 that are fixed in later 5.x releases, especially if you're using C++14.

That's a really bad choice of minimum version to insist on supporting.

Source: me, because I broke lots of stuff in 5.1 and then fixed it.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66259/new/

https://reviews.llvm.org/D66259





More information about the llvm-commits mailing list