[PATCH] D66344: Filesystem/Windows: fix inconsistency in readNativeFileSlice API
Alexandre Ganea via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 16 08:16:09 PDT 2019
aganea added inline comments.
================
Comment at: lib/Support/Windows/Path.inc:1233
+ // EOF is not an error.
+ if (Err == ERROR_BROKEN_PIPE || Err == ERROR_HANDLE_EOF)
return std::error_code();
----------------
Zachary also handles `ERROR_OPERATION_ABORTED` in `lldb/source/Host/windows/ConnectionGenericFileWindows.cpp` which corresponds to the user hitting Ctrl-C.
Also small nit not related to your change: we can't discriminate between a "full success" and a "eof success" from outside of this API, which could cause an extra loop to execute below? (and possibly trigger a different return code in `readNativeFileSlice`)
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66344/new/
https://reviews.llvm.org/D66344
More information about the llvm-commits
mailing list