[PATCH] D66330: Fix use-after-free in CodeGenPrepare

[Sanjay Patel via Phabricator via llvm-commits]

spatel accepted this revision.
spatel added a comment.

LGTM - in D63233 <https://reviews.llvm.org/D63233>, I added a TODO that I've marked here for reference, but this appears to be a minimal/safe fix.



================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:7019
 
   // TODO: Move this into the switch on opcode - it handles shifts already.
   if (BinOp && (BinOp->getOpcode() == Instruction::AShr ||
----------------
Alternative to this patch: act on that TODO.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66330/new/

https://reviews.llvm.org/D66330