[PATCH] D66141: [FileCheck] Forbid using var defined on same line

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added inline comments.


================
Comment at: llvm/test/FileCheck/numeric-expression.txt:180
 DEF-EXPR-FAIL-NEXT: [[# VAR20:]]
 DEF-EXPR-FAIL-NEXT: [[# VAR42: VAR20+22]]
 DEF-EXPR-FAIL-MSG: numeric-expression.txt:[[#@LINE-1]]:21: error: {{D}}EF-EXPR-FAIL-NEXT: is not on the line after the previous match
----------------
thopre wrote:
> jdenny wrote:
> > After the earlier removal in this file, is this the only remaining check that you can use a numeric variable within another's pattern?  There should probably be a positive check too.  Sorry if I overlooked one.
> There is a positive check removed above (see lines 85-92 in the before pane).
That's the removal I was referring to.  So, unless I overlooked one, there's now no positive check, but shouldn't there be one?  For example:

```
20
42
CHECK: [[# VAR20:]]
CHECK-NEXT: [[# VAR42: VAR20+22]]
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66141/new/

https://reviews.llvm.org/D66141