[PATCH] D66334: [LoopUnroll] Handle certain PHIs in full unrolling properly.

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 16 05:24:46 PDT 2019


lebedev.ri added inline comments.


================
Comment at: test/Transforms/LoopUnroll/full-unroll-miscompile.ll:8
+; CHECK-LABEL: main
+; CHECK: %.lcssa10.lcssa = phi i16 [ %tmp2, %for.cond.cleanup3 ]
+
----------------
ebevhan wrote:
> lebedev.ri wrote:
> > passing-by remark: it's way too fragile to test exact value names,
> > you may want to test more of the output (capturing the value names elsewhere),
> > if not all of it.
> I suppose I can generate the checks with the python script.
In this case i wasn't insisting on that - it gets pretty unreadable for large functions too.
But if it is autogenerated, you might as well precommit the original test.

<.. just passing by ..>


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66334/new/

https://reviews.llvm.org/D66334





More information about the llvm-commits mailing list