[PATCH] D66337: [AArch64InstrInfo] Stop getInstSizeInBytes returning non-zero for meta instructions.
Peter Smith via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 16 05:23:00 PDT 2019
peter.smith added a comment.
In D66337#1632855 <https://reviews.llvm.org/D66337#1632855>, @paulwalker-arm wrote:
> Have I got the terminology the wrong way round? I assumed relaxing meant the act of converting a branch who destination is not within range into a one that is within range either by inversion or introducing a second branch with sufficient range. I just want to make sure my commit message makes sense.
Sorry, I think it is me that has it wrong. I'm used to Linkers where relaxation can mean replace something like replace an expensive GlobalDynamic TLS sequence with a cheaper LocalDynamic one. In LLVM the branch relaxation pass starts with a small branch and replaces with a larger one if the smaller one is out of range so I think it is better to stick to your original one.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66337/new/
https://reviews.llvm.org/D66337
More information about the llvm-commits
mailing list