[PATCH] D66337: [AArch64InstrInfo] Stop getInstSizeInBytes returning non-zero for meta instructions.
Peter Smith via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 16 03:54:30 PDT 2019
peter.smith accepted this revision.
peter.smith added a comment.
This revision is now accepted and ready to land.
Looks good to me.
Cross checking against ARM to see if the same problem exists there, it looks like a different approach is taken, where anything unrecognized is assumed to be 0 size. This would handle meta instructions, but could underestimate block size if it came across something it didn't recognise. So I think this approach works best for AArch64.
> The net result is we might not relax a branch whose destination is not within range.
I'm guessing you mean, without this change we might not relax a branch whose destination is within range.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66337/new/
https://reviews.llvm.org/D66337
More information about the llvm-commits
mailing list