[PATCH] D66291: [test/Object] - Move/rewrite 2 more test cases.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: test/tools/llvm-objdump/relocations-in-nonreloc.test:25
+    Type:  SHT_RELA
+    Flags: [ SHF_ALLOC, SHF_INFO_LINK ]
+    Relocations:
----------------
jhenderson wrote:
> I don't think SHF_INFO_LINK is needed in any of these inputs.
Technically `SHF_ALLOC` or any other flags are also not needed.
I removed them.


================
Comment at: test/tools/llvm-objdump/relocations-in-nonreloc.test:29
+        Type:   R_X86_64_IRELATIVE
+        Addend: 0
+
----------------
MaskRay wrote:
> jhenderson wrote:
> > MaskRay wrote:
> > > Nit: non-zero r_offset & r_addend for IRELATIVE will be more realistic. At runtime, image_base + r_addend will be called as a function. r_addend should be non-zero.
> > I don't think we need this test to be particularly realistic. It just needs to have a relocation in it (I say R_X86_64_NONE to show it's suitably arbitrary), and show whether or not that relocation is printed.
> R_X86_64_NONE is not arbitrary but it will justify arbitrary r_offset/r_addend (so you can even omit r_addend)
I used `R_X86_64_NONE`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66291/new/

https://reviews.llvm.org/D66291