[PATCH] D66319: [ARM] Preserve liveness in ARMConstantIslands.

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added inline comments.


================
Comment at: lib/Target/ARM/ARMConstantIslandPass.cpp:881
 
+  // Collect liveness information at I.
+  LivePhysRegs LRs(*MF->getSubtarget().getRegisterInfo());
----------------
nit: "at I" -> "at MI"?


================
Comment at: test/CodeGen/ARM/constant-island-movwt.mir:901
 # CHECK-NEXT:   bb.2.entry (align 1):
+# CHECK-NEXT:   liveins:
+# CHECK-NEXT: {{^  $}}
----------------
Would it be useful to have, or add a test, that also has some liveins?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66319/new/

https://reviews.llvm.org/D66319