[PATCH] D66230: [coroutine] Fixes "cannot move instruction since its users are not dominated by CoroBegin" problem.

Gor Nishanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 15 20:33:38 PDT 2019


GorNishanov added a comment.

In D66230#1632510 <https://reviews.llvm.org/D66230#1632510>, @rjmccall wrote:

> Is there a case you're imagining where the adjustment would have side-effects?  Because I can see a reason to have an intrinsic that returns a frame pointer, but I don't see why that intrinsic would have any of the restrictions of `@llvm.coro.begin`.


Which restrictions are you thinking about?
Marking it as NoDuplicate in CoroEarly helps simplify the CoroSplit logic.
If you are thinking about the attributes on the intrinsic itself, those probably can be relaxed.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66230/new/

https://reviews.llvm.org/D66230





More information about the llvm-commits mailing list