[PATCH] D66322: [X86] Updated target specific selection dag code to conservatively check for isAtomic in addition to isVolatile
Philip Reames via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 15 16:45:45 PDT 2019
reames created this revision.
reames added reviewers: jlebar, jfb, RKSimon, craig.topper, efriedma.
Herald added subscribers: dexonsmith, bollu, mcrosier.
Herald added a project: LLVM.
See D66309 <https://reviews.llvm.org/D66309> for context.
This is the first sweep of generic code to add isAtomic bailouts where appropriate. The intention here is to have the switch from AtomicSDNode to LoadSDNode/StoreSDNode be close to NFC; that is, I'm not looking to allow additional optimizations at this time.
There are no todos in this patch, because as far as I can tell, all of the transforms apply to vectors only. At the moment, our atomics for vector story is a bit questionable, and that isn't a near term focus for me.
(Note: This is currently based on ToT without D66309 <https://reviews.llvm.org/D66309>. That's why there are no test diffs with the experimental flag visible. It could be added either before or after that change.)
Repository:
rL LLVM
https://reviews.llvm.org/D66322
Files:
lib/Target/X86/X86ISelDAGToDAG.cpp
lib/Target/X86/X86ISelLowering.cpp
lib/Target/X86/X86InstrInfo.td
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66322.215505.patch
Type: text/x-patch
Size: 6957 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190815/87a7490f/attachment.bin>
More information about the llvm-commits
mailing list