[PATCH] D64665: [MachinePipeliner] Refactor schedule emission logic

James Molloy via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 15 16:13:38 PDT 2019


Thankyou Jinsong!

Two test failures in the test-suite is very promising!

On Thu, 15 Aug 2019 at 13:43, Jinsong Ji via Phabricator <
reviews at reviews.llvm.org> wrote:

> jsji added a comment.
>
> Gave it a try on test-suite, with `-O3 -mcpu=pwr9 --ppc-enable-pipeliner`
>
> The following testcases failed with experimental codegen, while passed
> with origianl codegen.
>
>   test-suite :: MultiSource/Benchmarks/MallocBench/espresso/espresso.test
>   test-suite ::
> MultiSource/Benchmarks/MiBench/security-sha/security-sha.test
>
>
>
> ================
> Comment at: include/llvm/CodeGen/MachinePipeliner.h:361
>    void setMAX_II();
> +
>  };
> ----------------
> Extra new line
>
>
> ================
> Comment at: lib/CodeGen/MachineLoopUtils.cpp:1
> +//=- MachineLoopUtils.cpp - Functions for manipulating loops
> ----------------=//
> +//
> ----------------
> jsji wrote:
> > New file, you need to update `llvm/lib/CodeGen/CMakeLists.txt` as well.
> Still missing patch for `llvm/lib/CodeGen/CMakeLists.txt`.
>
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D64665/new/
>
> https://reviews.llvm.org/D64665
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190815/736727e2/attachment.html>


More information about the llvm-commits mailing list