[PATCH] D66274: [ELF][Hexagon] Replace R_HEXAGON_GOT with R_GOTPLT

[Sid Manning via Phabricator via llvm-commits]

sidneym added inline comments.


================
Comment at: ELF/InputSection.cpp:676
-  case R_HEXAGON_GOT:
-    return sym.getGotVA() - in.gotPlt->getVA();
   case R_MIPS_GOTREL:
----------------
sidneym wrote:
> Removing this will produce unexpected output.  GOT is the address in the GOT (G).  GOTREL is the difference between the location and table (S+A - GOT)
Ah, looking at the code more carefully I think this ok.  I was reading this as GOTPLTREL not GOTPLT.  Let me try to look back and see why this wasn't done in the first place.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66274/new/

https://reviews.llvm.org/D66274