[PATCH] D66165: Move isPointerOffset function to ValueTracking.

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis marked an inline comment as done.
eugenis added a comment.

I'll submit this as is and then refactor in a follow up.
Thanks!



================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:5700
+
+static int64_t getOffsetFromIndex(const GEPOperator *GEP, unsigned Idx,
+                                  bool &VariableIdxFound,
----------------
vitalybuka wrote:
> pair<int64_t, bool>
Even better, Optional<int64_t>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66165/new/

https://reviews.llvm.org/D66165