[PATCH] D66234: [MergedLoadStoreMotion] Sink stores to BB with more than 2 predecessors

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/MergedLoadStoreMotion.cpp:20
 // latencies, triggering if-conversion, and reducing static code size.
 //
 // NOTE: This code no longer performs load hoisting, it is subsumed by GVNHoist.
----------------
Could probably add something here that a new tail/footer block may be insterted if the tail/footer block has more predecessors (not only the two predecessors that are forming the diamond).


================
Comment at: llvm/lib/Transforms/Scalar/MergedLoadStoreMotion.cpp:286
+  succ_iterator SI = succ_begin(HeadBB);
+  assert(SI != succ_end(HeadBB));
+  BasicBlock *Pred0 = *SI;
----------------
coding rules: asserts should have a string


================
Comment at: llvm/lib/Transforms/Scalar/MergedLoadStoreMotion.cpp:289
+  ++SI;
+  assert(SI != succ_end(HeadBB));
+  BasicBlock *Pred1 = *SI;
----------------
coding rules: asserts should have a string


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66234/new/

https://reviews.llvm.org/D66234