[PATCH] D61669: [ValueTracking] Look through ptrmask intrinsics during getUnderlyingObject.
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 15 11:40:32 PDT 2019
This revision was automatically updated to reflect the committed changes.
Closed by commit rL369036: [ValueTracking] Look through ptrmask intrinsics during getUnderlyingObject. (authored by fhahn, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D61669?vs=207846&id=215449#toc
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61669/new/
https://reviews.llvm.org/D61669
Files:
llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp
llvm/trunk/lib/Analysis/ValueTracking.cpp
llvm/trunk/test/Analysis/BasicAA/ptrmask.ll
Index: llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp
===================================================================
--- llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp
+++ llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp
@@ -481,7 +481,7 @@
// because it should be in sync with CaptureTracking. Not using it may
// cause weird miscompilations where 2 aliasing pointers are assumed to
// noalias.
- if (auto *RP = getArgumentAliasingToReturnedPointer(Call, true)) {
+ if (auto *RP = getArgumentAliasingToReturnedPointer(Call, false)) {
V = RP;
continue;
}
Index: llvm/trunk/lib/Analysis/ValueTracking.cpp
===================================================================
--- llvm/trunk/lib/Analysis/ValueTracking.cpp
+++ llvm/trunk/lib/Analysis/ValueTracking.cpp
@@ -3677,7 +3677,9 @@
return Call->getIntrinsicID() == Intrinsic::launder_invariant_group ||
Call->getIntrinsicID() == Intrinsic::strip_invariant_group ||
Call->getIntrinsicID() == Intrinsic::aarch64_irg ||
- Call->getIntrinsicID() == Intrinsic::aarch64_tagp;
+ Call->getIntrinsicID() == Intrinsic::aarch64_tagp ||
+ (!MustPreserveNullness &&
+ Call->getIntrinsicID() == Intrinsic::ptrmask);
}
/// \p PN defines a loop-variant pointer to an object. Check if the
@@ -3735,7 +3737,7 @@
// because it should be in sync with CaptureTracking. Not using it may
// cause weird miscompilations where 2 aliasing pointers are assumed to
// noalias.
- if (auto *RP = getArgumentAliasingToReturnedPointer(Call, true)) {
+ if (auto *RP = getArgumentAliasingToReturnedPointer(Call, false)) {
V = RP;
continue;
}
Index: llvm/trunk/test/Analysis/BasicAA/ptrmask.ll
===================================================================
--- llvm/trunk/test/Analysis/BasicAA/ptrmask.ll
+++ llvm/trunk/test/Analysis/BasicAA/ptrmask.ll
@@ -0,0 +1,29 @@
+; RUN: opt -basicaa -aa-eval -print-no-aliases -disable-output %s 2>&1 | FileCheck %s
+
+%struct = type <{ [20 x i64] }>
+
+; CHECK-LABEL: Function: test_noalias: 4 pointers, 1 call sites
+; CHECK-NEXT: NoAlias: %struct* %ptr1, i64* %ptr2
+; CHECK-NEXT: NoAlias: %struct* %addr.ptr, i64* %ptr2
+; CHECK-NEXT: NoAlias: i64* %gep, i64* %ptr2
+define void @test_noalias(%struct* noalias %ptr1, i64* %ptr2, i64 %offset) {
+entry:
+ %addr.ptr = call %struct* @llvm.ptrmask.p0s_struct.p0s.struct.i64(%struct* %ptr1, i64 72057594037927928)
+ store i64 10, i64* %ptr2
+ %gep = getelementptr inbounds %struct, %struct* %addr.ptr, i64 0, i32 0, i64 %offset
+ store i64 1, i64* %gep, align 8
+ ret void
+}
+
+; CHECK-NEXT: Function: test_alias: 4 pointers, 1 call sites
+; CHECK-NOT: NoAlias
+define void @test_alias(%struct* %ptr1, i64* %ptr2, i64 %offset) {
+entry:
+ %addr.ptr = call %struct* @llvm.ptrmask.p0s_struct.p0s.struct.i64(%struct* %ptr1, i64 72057594037927928)
+ store i64 10, i64* %ptr2
+ %gep = getelementptr inbounds %struct, %struct* %addr.ptr, i64 0, i32 0, i64 %offset
+ store i64 1, i64* %gep, align 8
+ ret void
+}
+
+declare %struct* @llvm.ptrmask.p0s_struct.p0s.struct.i64(%struct*, i64)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61669.215449.patch
Type: text/x-patch
Size: 3217 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190815/896cdacc/attachment.bin>
More information about the llvm-commits
mailing list