[PATCH] D66244: Compiler.h: remove old GCC checks, update docs

JF Bastien via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 15 10:37:53 PDT 2019


jfb marked 2 inline comments as done.
jfb added inline comments.


================
Comment at: llvm/include/llvm/Support/Compiler.h:356
 #elif defined(LLVM_BUILTIN_UNREACHABLE)
 // As of today, clang does not support __builtin_assume_aligned.
 # define LLVM_ASSUME_ALIGNED(p, a) \
----------------
xbolva00 wrote:
> Outdated?  
> 
> https://github.com/llvm-mirror/clang/blob/master/test/Sema/builtin-assume-aligned.c
The comment is, but it's still true: it was added in llvm.org/r217349 from September 7th 2014 and the minimum clang supported right now is 3.5, released on September 3rd  2014. I'll update the comment, because the check `_has_builtin(__builtin_assume_aligned)` is sufficient.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66244/new/

https://reviews.llvm.org/D66244





More information about the llvm-commits mailing list