[llvm] r369011 - [cmake] install_symlink should obey DESTDIR unconditionally

[Justin Bogner via llvm-commits]

Tom Stellard <tstellar at redhat.com> writes:
> On 08/15/2019 08:36 AM, Justin Bogner via llvm-commits wrote:
>> Author: bogner
>> Date: Thu Aug 15 08:36:13 2019
>> New Revision: 369011
>> 
>
> Should we backport this to the 9.x branch?

It certainly wouldn't hurt, but given how long it was before anyone
complained I'm guessing that not a lot of people are affected.

> -Tom
>
>> URL: http://llvm.org/viewvc/llvm-project?rev=369011&view=rev
>> Log:
>> [cmake] install_symlink should obey DESTDIR unconditionally
>> 
>> Setting DESTDIR was erroneously buried under a condition here - if
>> it's set it should always be used.
>> 
>> Modified:
>>     llvm/trunk/cmake/modules/LLVMInstallSymlink.cmake
>> 
>> Modified: llvm/trunk/cmake/modules/LLVMInstallSymlink.cmake
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/LLVMInstallSymlink.cmake?rev=369011&r1=369010&r2=369011&view=diff
>> ==============================================================================
>> --- llvm/trunk/cmake/modules/LLVMInstallSymlink.cmake (original)
>> +++ llvm/trunk/cmake/modules/LLVMInstallSymlink.cmake Thu Aug 15 08:36:13 2019
>> @@ -3,9 +3,9 @@
>>  # See PR8397.
>>  
>>  function(install_symlink name target outdir)
>> +  set(DESTDIR $ENV{DESTDIR})
>>    if(CMAKE_HOST_UNIX)
>>      set(LINK_OR_COPY create_symlink)
>> -    set(DESTDIR $ENV{DESTDIR})
>>    else()
>>      set(LINK_OR_COPY copy)
>>    endif()
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>