[PATCH] D65367: [Object] Create MutableELFObject Class for Doing Mutations on ELFObjectFiles [Part 2]
Alex Brachet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 15 09:30:45 PDT 2019
abrachet marked 2 inline comments as done.
abrachet added inline comments.
================
Comment at: llvm/unittests/Object/MutableELFObjectTest.cpp:352
+
+ auto TestSym = symbol_iterator(++MutableObject.symbol_begin());
+ Expected<MutableELFSymbol<ELF64LE> &> MutSymOrErr =
----------------
jhenderson wrote:
> You've made a change to address my comment for this style above. Please make the same change throughout. It wasn't a local issue for my earlier point :)
Sorry about that, silly mistake.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65367/new/
https://reviews.llvm.org/D65367
More information about the llvm-commits
mailing list