[PATCH] D66286: [llvm-readobj/llvm-readelf] - Improve/cleanup the error reporting API.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: tools/llvm-readobj/ELFDumper.cpp:4623
   uint64_t RelocSymValue = 0;
-  StringRef FileStr = Obj->getFileName();
+
   if (RelocSym != Obj->symbol_end()) {
----------------
I think if a variable already exists, keeping it probably doesn't hurt. Typing `Obj->getFileName()` takes a bit more characters.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66286/new/

https://reviews.llvm.org/D66286