[PATCH] D66291: [test/Object] - Move/rewrite 2 more test cases.

Thu Aug 15 07:39:21 PDT 2019

MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.

================
Comment at: test/tools/llvm-objdump/relocations-in-nonreloc.test:29
+        Type:   R_X86_64_IRELATIVE
+        Addend: 0
+
----------------
Nit: non-zero r_offset & r_addend for IRELATIVE will be more realistic. At runtime, image_base + r_addend will be called as a function. r_addend should be non-zero.

================
Comment at: test/tools/llvm-objdump/relocations-in-nonreloc.test:60
+      - Offset: 0x0
+        Type:   R_X86_64_IRELATIVE
+        Addend: 0
----------------
Nit: assemblers do not produce `R_X86_64_IRELATIVE` (i.e. they should not appear in object files). You can use a different one, e.g. PLT32. (I believe IRELATIVE in .rela.plt is a historical GNU mistake, see D65651)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66291/new/

https://reviews.llvm.org/D66291