[PATCH] D65950: [RISCV] Add Option for Printing Architectural Register Names

[Sam Elliott via Phabricator via llvm-commits]

lenary marked an inline comment as done.
lenary added inline comments.


================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVInstPrinter.h:51
                                const MCSubtargetInfo &STI, raw_ostream &O);
-  static const char *getRegisterName(unsigned RegNo,
-                                     unsigned AltIdx = RISCV::ABIRegAltName);
+  static const char *getRegisterName(unsigned RegNo);
+  static const char *getRegisterName(unsigned RegNo, unsigned AltIdx);
----------------
luismarques wrote:
> Does this fall under the umbrella of the `unsigned` -> `Register` type transition? If so, please update the patch accordingly. (Apply the comment to the other cases in this patch).
Not yet, because the two-argument version is generated by tablegen.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65950/new/

https://reviews.llvm.org/D65950