[PATCH] D65190: [X86] X86ATTInstPrinter: replace markup with startMarkup/endMarkup
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 15 03:44:14 PDT 2019
jhenderson accepted this revision.
jhenderson added a comment.
LGTM.
================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86ATTInstPrinter.cpp:379-381
+ O << startMarkup(MarkupType::Imm) << '$';
Op.getExpr()->print(O, &MAI);
+ O << endMarkup();
----------------
seiya wrote:
> jhenderson wrote:
> > No need for this to be part of this change, but I find it slightly odd that you can't use the withMarkup pattern here. I take it that making the print function return a stream wouldn't be straightforward?
> > I take it that making the print function return a stream wouldn't be straightforward?
> Does "return a stream" mean `raw_ostream &MCExpr::print(raw_ostream &OS, ...);` instead of `void MCExpr::print(...)`?
Yes, that's what I meant.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65190/new/
https://reviews.llvm.org/D65190
More information about the llvm-commits
mailing list