[PATCH] D66281: [llvm-objcopy][MachO] Implement --strip-all

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/MachO/strip-all.test:1
+# RUN: yaml2obj %p/Inputs/strip-all.yaml > %t.exec
+# RUN: yaml2obj %p/Inputs/strip-all-with-dwarf.yaml > %t.dwarf
----------------
You need a comment at the start of this test explaining what the test does.


================
Comment at: llvm/test/tools/llvm-objcopy/MachO/strip-all.test:12-13
+
+## The output of "llvm-strip --strip-all" should be identical with that of
+## "llvm-objcopy --strip-all".
+# RUN: llvm-strip --strip-all %t.exec -o %t2
----------------
Also llvm-strip without "--strip-all" should be the same as "llvm-objcopy--strip-all". Test that too.


================
Comment at: llvm/test/tools/llvm-objcopy/MachO/strip-all.test:37
+# COMMON-NEXT: ]
\ No newline at end of file

----------------
No new line at EOF.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66281/new/

https://reviews.llvm.org/D66281