[PATCH] D66283: [llvm-objcopy][MachO] Implement --add-section

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/MachO/add-section.test:1
+## Show that if llvm-objcopy adds a new section into the object if
+## --add-section is given.
----------------
Remove the "if" before llvm-objcopy


================
Comment at: llvm/test/tools/llvm-objcopy/MachO/add-section.test:7
+
+# RUN: not llvm-objcopy --add-section __text=%t.data %t %t.invalid-section-name 2>&1 \
+# RUN:   | FileCheck %s -DINPUT=%t --check-prefix=INVALID-SECTION-NAME
----------------
You also need a test case for what happens if %t.data doesn't exist.


================
Comment at: llvm/test/tools/llvm-objcopy/MachO/add-section.test:106
+# CASE2-NEXT: }
\ No newline at end of file

----------------
Nit: no new line at EOF.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66283/new/

https://reviews.llvm.org/D66283