[PATCH] D66277: [ELF][AArch64] Improve error message for unknown relocations

[George Rimar via Phabricator via llvm-commits]

grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.

LGTM. 2 nits are below.



================
Comment at: test/ELF/invalid/invalid-relocation-aarch64.test:3
+# RUN: yaml2obj %s -o %t.o
+# RUN: not ld.lld %t.o --defsym=foo=0 -o /dev/null 2>&1 | FileCheck %s
+# CHECK: error: unknown relocation (1024) against symbol foo
----------------
Why do you need `--defsym=foo=0`? 


================
Comment at: test/ELF/invalid/invalid-relocation-aarch64.test:11
+  Data:            ELFDATA2LSB
+  OSABI:           ELFOSABI_FREEBSD
+  Type:            ET_REL
----------------
I think you do not need "OSABI".


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66277/new/

https://reviews.llvm.org/D66277