[PATCH] D66259: Migrate llvm::make_unique to std::make_unique

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 14 15:13:48 PDT 2019


JDevlieghere added a comment.

In D66259#1630454 <https://reviews.llvm.org/D66259#1630454>, @jfb wrote:

> BTW, if this breaks stuff maybe it's better to do it one project at a time, and remove the helper at the very end.


Yep, that sounds like a good approach. Removing the helper was useful for finding cases my regex missed :-)



================
Comment at: llvm/include/llvm/ADT/STLExtras.h:1429
-
-struct FreeDeleter {
-  void operator()(void* v) {
----------------
jfb wrote:
> This is used in `NativeRegisterContextLinux_x86_64.h`
Good catch!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66259/new/

https://reviews.llvm.org/D66259





More information about the llvm-commits mailing list