[PATCH] D65189: [MC] Support returning marked up ranges in the disassembly

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

LGTM. No need to get further review from my point of view after you've fixed my remaining nit.



================
Comment at: llvm/include/llvm/MC/MCInstPrinter.h:214-215
   StringRef markup(StringRef s) const;
+  MarkupStart startMarkup(MarkupType Type)  const;
+  MarkupEnd endMarkup()  const;
+  WithMarkup withMarkup(raw_ostream &OS, MarkupType Type) const;
----------------
Nit: looks like you've got two spaces before the `const` in these two lines.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65189/new/

https://reviews.llvm.org/D65189