[PATCH] D64176: [Bugpoint redesign] Added Pass to Remove Global Variables

[Florian Hahn via llvm-commits]

Hi, 

Is it possible that this change causes some of there Reduce tests to fail non-deterministically? 2 out of the 3 latest builds of clang-ppc64be-linux-lnt failed different test cases from Reduce without any changes to Reduce. The links to the builds are

http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt/builds/29966 <http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt/builds/29966> remove-funcs.ll failed
http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt/builds/29965 <http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt/builds/29965> all passed
http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt/builds/29964 <http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt/builds/29964> remove-global-vars.ll failed


The failures were
******************** TEST 'LLVM :: Reduce/remove-funcs.ll' FAILED ********************
Script:
--
: 'RUN: at line 4';   llvm-reduce --test /home/buildbots/ppc64be-clang-lnt-test/clang-ppc64be-lnt/llvm/test/Reduce/Inputs/remove-funcs.py /home/buildbots/ppc64be-clang-lnt-test/clang-ppc64be-lnt/llvm/test/Reduce/remove-funcs.ll
: 'RUN: at line 5';   cat reduced.ll | /home/buildbots/ppc64be-clang-lnt-test/clang-ppc64be-lnt/stage1/bin/FileCheck /home/buildbots/ppc64be-clang-lnt-test/clang-ppc64be-lnt/llvm/test/Reduce/remove-funcs.ll
--
Exit Code: 1

Command Output (stdout):
--
Reducing functions...
*** Reducing Functions...
----------------------------
Function Index Reference:
	1: uninteresting1
	2: interesting
	3: uninteresting2
	4: uninteresting3
----------------------------
Increasing granularity...Success! New Chunks:
	[1,2]
	[3,4]
Testing with: [1,2] | tmp-f36.ll **** SUCCESS | lines: 14
Increasing granularity...Success! New Chunks:
	[1]
	[2]
Testing with: [1] | tmp-535.ll
Testing with: [2] | tmp-1b6.ll **** SUCCESS | lines: 8
Increasing granularity...Couldn't increase anymore.
----------------------------
Reducing GVs...
*** Reducing GVs...
----------------------------
GlobalVariable Index Reference:
----------------------------

Nothing to reduce

Done reducing! Reduced IR to file: reduced.ll

--
Command Output (stderr):
--
/home/buildbots/ppc64be-clang-lnt-test/clang-ppc64be-lnt/llvm/test/Reduce/remove-funcs.ll:14:10: error: CHECK: expected string not found in input
; CHECK: interesting()
         ^
<stdin>:1:1: note: scanning from here
; ModuleID = '/home/buildbots/ppc64be-clang-lnt-test/clang-ppc64be-lnt/llvm/test/Reduce/remove-global-vars.ll'
^
<stdin>:4:2: note: possible intended match here
@interesting = global i32 0, align 4
 ^

--

********************


******************** TEST 'LLVM :: Reduce/remove-global-vars.ll' FAILED ********************
Script:
--
: 'RUN: at line 4';   llvm-reduce --test /home/buildbots/ppc64be-clang-lnt-test/clang-ppc64be-lnt/llvm/test/Reduce/Inputs/remove-global-vars.py /home/buildbots/ppc64be-clang-lnt-test/clang-ppc64be-lnt/llvm/test/Reduce/remove-global-vars.ll
: 'RUN: at line 5';   cat reduced.ll | /home/buildbots/ppc64be-clang-lnt-test/clang-ppc64be-lnt/stage1/bin/FileCheck /home/buildbots/ppc64be-clang-lnt-test/clang-ppc64be-lnt/llvm/test/Reduce/remove-global-vars.ll
--
Exit Code: 1

Command Output (stdout):
--
Reducing functions...
*** Reducing Functions...
----------------------------
Function Index Reference:
	1: main
----------------------------
Increasing granularity...
Already at minimum size. Cannot reduce anymore.
----------------------------
Reducing GVs...
*** Reducing GVs...
----------------------------
GlobalVariable Index Reference:
	1: interesting
	2: uninteresting
----------------------------
Increasing granularity...Success! New Chunks:
	[1]
	[2]
Testing with: [1] | tmp-7bc.ll **** SUCCESS | lines: 13
Increasing granularity...Couldn't increase anymore.

Done reducing! Reduced IR to file: reduced.ll

--
Command Output (stderr):
--
/home/buildbots/ppc64be-clang-lnt-test/clang-ppc64be-lnt/llvm/test/Reduce/remove-global-vars.ll:8:10: error: CHECK: expected string not found in input
; CHECK: @interesting = global
         ^
<stdin>:1:1: note: scanning from here
; ModuleID = '/home/buildbots/ppc64be-clang-lnt-test/clang-ppc64be-lnt/llvm/test/Reduce/remove-funcs.ll'
^
<stdin>:4:12: note: possible intended match here
define i32 @interesting() {
           ^

--

********************

Cheers,
Florian


Ps: I could not find the commit email on llvm-commits, just the Phabricator ones.



> On Aug 14, 2019, at 22:01, Phabricator via Phabricator <reviews at reviews.llvm.org> wrote:
> 
> This revision was automatically updated to reflect the committed changes.
> Closed by commit rGd1ffcd07456b: [Bugpoint redesign] Added Pass to Remove Global Variables (authored by Diego Trevino Ferrer <diegof30 at gmail.com>).
> 
> Repository:
>  rG LLVM Github Monorepo
> 
> CHANGES SINCE LAST ACTION
>  https://reviews.llvm.org/D64176/new/
> 
> https://reviews.llvm.org/D64176
> 
> Files:
>  llvm/test/Reduce/Inputs/remove-global-vars.py
>  llvm/test/Reduce/remove-funcs.ll
>  llvm/test/Reduce/remove-global-vars.ll
>  llvm/tools/llvm-reduce/CMakeLists.txt
>  llvm/tools/llvm-reduce/DeltaManager.h
>  llvm/tools/llvm-reduce/deltas/ReduceGlobalVars.cpp
>  llvm/tools/llvm-reduce/deltas/ReduceGlobalVars.h
> 
> <D64176.215240.patch>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190815/2365c825/attachment.html>