[PATCH] D66216: [ValueTracking] Fix recurrence detection to check both PHI operands.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 15 02:02:02 PDT 2019


fhahn marked an inline comment as done.
fhahn added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/phi-known-bits-operand-order.ll:1
+; RUN: opt -instcombine -S < %s | FileCheck %s
+
----------------
lebedev.ri wrote:
> Please use `utils/update_test_checks.py` and precommit.
Done.
I am a bit torn when it come sousing update_test_checks.py here, as checking everything potentially makes the test slightly more verbose and brittle than necessary. But it is quite convenient.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66216/new/

https://reviews.llvm.org/D66216





More information about the llvm-commits mailing list