[PATCH] D66190: [CodeGen] Add a pass to do block predication on SSA machine IR

[Thomas Raoux via Phabricator via llvm-commits]

ThomasRaoux marked an inline comment as done.
ThomasRaoux added inline comments.


================
Comment at: llvm/lib/CodeGen/EarlyIfConversion.cpp:930-932
+//===----------------------------------------------------------------------===//
+//                           EarlyIfPredicator Pass
+//===----------------------------------------------------------------------===//
----------------
lebedev.ri wrote:
> ThomasRaoux wrote:
> > lebedev.ri wrote:
> > > I'd think you want to not jam it next to existing pass, but put it into it's own place
> > Do you mean move it into its own file? This reuses SSAIfConv infrastructure so unless we move it into a header file those two passes have to be in the same file.
> Yes
So you are suggesting moving SSAIfConv into a common header? I don't have a strong opinion about it but there are several cases of passes sharing a file and I suppose limiting exposure of the helper has its advantage.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66190/new/

https://reviews.llvm.org/D66190