[compiler-rt] r368952 - Revert "[compiler-rt] Migrate llvm::make_unique to std::make_unique"

[Jonas Devlieghere via llvm-commits]

Author: jdevlieghere
Date: Wed Aug 14 20:02:57 2019
New Revision: 368952

URL: http://llvm.org/viewvc/llvm-project?rev=368952&view=rev
Log:
Revert "[compiler-rt] Migrate llvm::make_unique to std::make_unique"

The X-ray unit tests in compiler-rt are overriding the C++ version by
explicitly passing -std=c++11 in the compiler invocation. This poses a
problem as these tests are including LLVM headers that can now use C++14
features. I'm temporarily reverting this as I investigate the correct
solution.

Modified:
    compiler-rt/trunk/lib/xray/tests/unit/fdr_controller_test.cpp

Modified: compiler-rt/trunk/lib/xray/tests/unit/fdr_controller_test.cpp
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/xray/tests/unit/fdr_controller_test.cpp?rev=368952&r1=368951&r2=368952&view=diff
==============================================================================
--- compiler-rt/trunk/lib/xray/tests/unit/fdr_controller_test.cpp (original)
+++ compiler-rt/trunk/lib/xray/tests/unit/fdr_controller_test.cpp Wed Aug 14 20:02:57 2019
@@ -51,11 +51,11 @@ protected:
 public:
   void SetUp() override {
     bool Success;
-    BQ = std::make_unique<BufferQueue>(4096, 1, Success);
+    BQ = llvm::make_unique<BufferQueue>(4096, 1, Success);
     ASSERT_TRUE(Success);
     ASSERT_EQ(BQ->getBuffer(B), BufferQueue::ErrorCode::Ok);
-    W = std::make_unique<FDRLogWriter>(B);
-    C = std::make_unique<FDRController<>>(BQ.get(), B, *W, clock_gettime, 0);
+    W = llvm::make_unique<FDRLogWriter>(B);
+    C = llvm::make_unique<FDRController<>>(BQ.get(), B, *W, clock_gettime, 0);
   }
 };
 
@@ -103,7 +103,7 @@ TEST_F(FunctionSequenceTest, BoundaryFun
 }
 
 TEST_F(FunctionSequenceTest, ThresholdsAreEnforced) {
-  C = std::make_unique<FDRController<>>(BQ.get(), B, *W, clock_gettime, 1000);
+  C = llvm::make_unique<FDRController<>>(BQ.get(), B, *W, clock_gettime, 1000);
   ASSERT_TRUE(C->functionEnter(1, 2, 3));
   ASSERT_TRUE(C->functionExit(1, 2, 3));
   ASSERT_TRUE(C->flush());
@@ -118,7 +118,7 @@ TEST_F(FunctionSequenceTest, ThresholdsA
 }
 
 TEST_F(FunctionSequenceTest, ArgsAreHandledAndKept) {
-  C = std::make_unique<FDRController<>>(BQ.get(), B, *W, clock_gettime, 1000);
+  C = llvm::make_unique<FDRController<>>(BQ.get(), B, *W, clock_gettime, 1000);
   ASSERT_TRUE(C->functionEnterArg(1, 2, 3, 4));
   ASSERT_TRUE(C->functionExit(1, 2, 3));
   ASSERT_TRUE(C->flush());
@@ -138,7 +138,7 @@ TEST_F(FunctionSequenceTest, ArgsAreHand
 }
 
 TEST_F(FunctionSequenceTest, PreservedCallsHaveCorrectTSC) {
-  C = std::make_unique<FDRController<>>(BQ.get(), B, *W, clock_gettime, 1000);
+  C = llvm::make_unique<FDRController<>>(BQ.get(), B, *W, clock_gettime, 1000);
   uint64_t TSC = 1;
   uint16_t CPU = 0;
   ASSERT_TRUE(C->functionEnter(1, TSC++, CPU));
@@ -163,7 +163,7 @@ TEST_F(FunctionSequenceTest, PreservedCa
 }
 
 TEST_F(FunctionSequenceTest, PreservedCallsSupportLargeDeltas) {
-  C = std::make_unique<FDRController<>>(BQ.get(), B, *W, clock_gettime, 1000);
+  C = llvm::make_unique<FDRController<>>(BQ.get(), B, *W, clock_gettime, 1000);
   uint64_t TSC = 1;
   uint16_t CPU = 0;
   const auto LargeDelta = uint64_t{std::numeric_limits<int32_t>::max()};
@@ -187,7 +187,7 @@ TEST_F(FunctionSequenceTest, PreservedCa
 }
 
 TEST_F(FunctionSequenceTest, RewindingMultipleCalls) {
-  C = std::make_unique<FDRController<>>(BQ.get(), B, *W, clock_gettime, 1000);
+  C = llvm::make_unique<FDRController<>>(BQ.get(), B, *W, clock_gettime, 1000);
 
   // First we construct an arbitrarily deep function enter/call stack.
   // We also ensure that we are in the same CPU.
@@ -214,7 +214,7 @@ TEST_F(FunctionSequenceTest, RewindingMu
 }
 
 TEST_F(FunctionSequenceTest, RewindingIntermediaryTailExits) {
-  C = std::make_unique<FDRController<>>(BQ.get(), B, *W, clock_gettime, 1000);
+  C = llvm::make_unique<FDRController<>>(BQ.get(), B, *W, clock_gettime, 1000);
 
   // First we construct an arbitrarily deep function enter/call stack.
   // We also ensure that we are in the same CPU.
@@ -248,7 +248,7 @@ TEST_F(FunctionSequenceTest, RewindingIn
 }
 
 TEST_F(FunctionSequenceTest, RewindingAfterMigration) {
-  C = std::make_unique<FDRController<>>(BQ.get(), B, *W, clock_gettime, 1000);
+  C = llvm::make_unique<FDRController<>>(BQ.get(), B, *W, clock_gettime, 1000);
 
   // First we construct an arbitrarily deep function enter/call stack.
   // We also ensure that we are in the same CPU.
@@ -303,13 +303,13 @@ protected:
 public:
   void SetUp() override {
     bool Success;
-    BQ = std::make_unique<BufferQueue>(sizeof(MetadataRecord) * 5 +
+    BQ = llvm::make_unique<BufferQueue>(sizeof(MetadataRecord) * 5 +
                                             sizeof(FunctionRecord) * 2,
                                         kBuffers, Success);
     ASSERT_TRUE(Success);
     ASSERT_EQ(BQ->getBuffer(B), BufferQueue::ErrorCode::Ok);
-    W = std::make_unique<FDRLogWriter>(B);
-    C = std::make_unique<FDRController<>>(BQ.get(), B, *W, clock_gettime, 0);
+    W = llvm::make_unique<FDRLogWriter>(B);
+    C = llvm::make_unique<FDRController<>>(BQ.get(), B, *W, clock_gettime, 0);
   }
 };