[PATCH] D66195: Move to C++14
Duncan P. N. Exon Smith via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 14 18:47:08 PDT 2019
dexonsmith added inline comments.
================
Comment at: llvm/trunk/include/llvm/Support/type_traits.h:195-199
+#if defined(__cplusplus) || defined(_MSC_VER)
#define LLVM_IS_FINAL(Ty) std::is_final<Ty>()
#elif __has_feature(is_final) || LLVM_GNUC_PREREQ(4, 7, 0)
#define LLVM_IS_FINAL(Ty) __is_final(Ty)
#endif
----------------
It seems like we don't need `LLVM_IS_FINAL` anymore, given that `#if defined(__cplusplus)` looks like it would always be true for this header. At least we can remove the `#if` guard.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66195/new/
https://reviews.llvm.org/D66195
More information about the llvm-commits
mailing list