[PATCH] D64665: [MachinePipeliner] Refactor schedule emission logic

David Majnemer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 14 16:58:01 PDT 2019


majnemer added inline comments.


================
Comment at: lib/CodeGen/MachineLoopUtils.cpp:57
+  // FIXME: Add DenseMapInfo trait for Register so we can use it as a key.
+  DenseMap<unsigned, Register> Remaps;
+  auto InsertPt = NewBB->end();
----------------
Can this be `DenseMap<Register, Register>`?


================
Comment at: lib/CodeGen/MachineLoopUtils.cpp:64-65
+      Register OrigR = MO.getReg();
+      if (OrigR.isPhysical())
+        continue;
+      Register &R = Remaps[OrigR];
----------------
Maybe have a comment explaining this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64665/new/

https://reviews.llvm.org/D64665





More information about the llvm-commits mailing list