[PATCH] D66120: [Attributor] Use liveness during the creation of AAReturnedValues

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 14 16:43:35 PDT 2019


jdoerfert marked an inline comment as done.
jdoerfert added inline comments.


================
Comment at: llvm/trunk/lib/Transforms/IPO/Attributor.cpp:730
+    ReturnInst &Ret = cast<ReturnInst>(I);
+    RVState RVS({ReturnedValues, false});
+    RVS.RetInsts.insert(&Ret);
----------------
rupprecht wrote:
> This introduces a new warning due to omitting the RetInsts field here:
> 
> ```
> [956/4588] Building CXX object lib/Transforms/IPO/CMakeFiles/LLVMipo.dir/Attributor.cpp.o
> ~/src/llvm-project/llvm/lib/Transforms/IPO/Attributor.cpp:738:39: warning: missing field 'RetInsts' initializer [-Wmissing-field-initializers]                                                                
>     RVState RVS({ReturnedValues, false});
> ```
I saw it and fixed it. Thx for reporting!


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66120/new/

https://reviews.llvm.org/D66120





More information about the llvm-commits mailing list