[PATCH] D58311: [MemorySSA & LoopPassManager] Enable MemorySSA as loop dependency. Update tests.

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 14 16:21:22 PDT 2019


chandlerc added a comment.

As we discussed in person, we should refactor this so that when we enable MemorySSA we actually check the the loop passes in question mnanage to preserve it.



================
Comment at: lib/Transforms/Utils/LoopUtils.cpp:173-178
+  // FIXME: enable when all loop passes preserve MemorySSA.
+  // Remove individual handling in each pass when that happens.
+  if (false) {
+    AU.addRequired<MemorySSAWrapperPass>();
+    AU.addPreserved<MemorySSAWrapperPass>();
+  }
----------------
I think you can just remove this for now.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58311/new/

https://reviews.llvm.org/D58311





More information about the llvm-commits mailing list