[PATCH] D66110: [Bugpoint redesign] Added option to run only certain delta passes

Diego TreviƱo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 14 15:32:29 PDT 2019


diegotf abandoned this revision.
diegotf added a comment.

In D66110#1630478 <https://reviews.llvm.org/D66110#1630478>, @dblaikie wrote:

> I still feel like it'd probably be better to try to come up with some reliable/simple-enough idioms in the interestingness tests - rather than having more flags for the tool (even if they're only intended for test purposes).
>
> I understand golden files in tests are usually not a great idea - but what would happen if the interestingness test was an exact IR file of the expected output, I wonder? Specifically the purpose being to demonstrate whether the reduction tool can get from the input to the output. Unlike other golden file situations that become hard to maintain as the tool changes its behavior, etc, in llvm-reduce the goal is that no matter how much better/different the tool gets, it can still manage every specific mapping from input to output.


Fair enough. My main focus was simplifying the interesting-ness tests, but I can't argue with the last point. I'll go ahead and close this diff


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66110/new/

https://reviews.llvm.org/D66110





More information about the llvm-commits mailing list