[PATCH] D66256: [AIX] Use GCC-style -std and warning options for XL

Wed Aug 14 14:46:19 PDT 2019

jfb added a comment.

In D66256#1630347 <https://reviews.llvm.org/D66256#1630347>, @hubert.reinterpretcast wrote:

> In D66256#1630326 <https://reviews.llvm.org/D66256#1630326>, @jfb wrote:
>
> > Can XL enable all the same flags which GCC can?
>
>
> It can except the modules stuff, which should would be detected via the `CHECK_CXX_SOURCE_COMPILES`.
>
> > There's a lot under that `elseif`!
>
> Most of it is the modules stuff.
>
> > At that point, isn't XL GCC compatible?
>
> It isn't, because the object-file generation options (e.g., `-fno-unwind-tables`) differ.
>
> I guess I should say "default warning" options in the commit message, because the `LLVM_ENABLE_WARNINGS` and `LLVM_ENABLE_PEDANTIC` modes aren't enabled with this patch.

I'm worried because this entire section is for "GCC compatible command line stuff". If someone added something new in there, would it inadvertently break XL? Maybe it's better to factor out the bits you want to enable and leave the rest separate from XL?

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66256/new/

https://reviews.llvm.org/D66256