[PATCH] D66230: [coroutine] Fixes "cannot move instruction since its users are not dominated by CoroBegin" problem.
Brian Gesiak via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 14 12:25:18 PDT 2019
modocache accepted this revision.
modocache added a comment.
This revision is now accepted and ready to land.
Thanks for looking into this, @GorNishanov! LGTM aside from a tiny nit-pick.
================
Comment at: lib/Transforms/Coroutines/CoroFrame.cpp:476
+ const DataLayout &DL = A.getModule()->getDataLayout();
+ AllocaUseVisitor v(DL, DT, CB);
+ auto PtrI = v.visitPtr(A);
----------------
A nit-pick, but: it seems like most other variable names in this function are capitalized (e.g.: `PtrI`), but this one is a lowercase `v`. Is there a reason they're not consistent?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66230/new/
https://reviews.llvm.org/D66230
More information about the llvm-commits
mailing list