[PATCH] D66197: AMDGPU: Add intrinsics for address space identification

Wed Aug 14 11:39:13 PDT 2019

jdoerfert added a comment.

In D66197#1629809 <https://reviews.llvm.org/D66197#1629809>, @b-sumner wrote:

> In D66197#1629784 <https://reviews.llvm.org/D66197#1629784>, @jdoerfert wrote:
>
> > Do we really need these to be "amdgpu" specific?
>
>
> Are you envisioning these would be used for OpenCL implementations?  OpenCL doesn't exactly have these.  It instead has to_<addrspacename> functions which return NULL if the generic pointer isn't actually pointing at a object in <addrrspacename>.

We (will) have various languages/targets that have corresponding address spaces and we already reserve some numbers for specific address spaces (afaik), why not make this a generic functionality.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66197/new/

https://reviews.llvm.org/D66197