[PATCH] D66161: [SLC] Dereferenceable annonation - handle valid null pointers

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 14 10:08:56 PDT 2019


jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

In D66161#1629559 <https://reviews.llvm.org/D66161#1629559>, @reames wrote:

> I have no problem with this patch (i.e. it can land if Johannes approves)


LGTM.

> A conceptual point worth mentioning is that seems to essentially be inferring non-null for the intrinsics in question.  We have a nonnull attribute on params and nonnull + deref_or_null should already be converted to deref.  (If not, we should fix that.)  It might be worth thinking about how to leverage the more generic code.

The Attributor does this already but there are a few points where we need to improve it.
I think these patches should encode "known" information and the Attributor (run early) will combine whatever it can.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66161/new/

https://reviews.llvm.org/D66161





More information about the llvm-commits mailing list