[PATCH] D66161: [SLC] Dereferenceable annonation - handle valid null pointers

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 14 09:46:46 PDT 2019


reames added a comment.

I have no problem with this patch (i.e. it can land if Johannes approves)

A conceptual point worth mentioning is that seems to essentially be inferring non-null for the intrinsics in question.  We have a nonnull attribute on params and nonnull + deref_or_null should already be converted to deref.  (If not, we should fix that.)  It might be worth thinking about how to leverage the more generic code.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66161/new/

https://reviews.llvm.org/D66161





More information about the llvm-commits mailing list