[PATCH] D66166: [WebAssembly] Stop unrolling SIMD shifts since they are fixed in V8

[Thomas Lively via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL368868: [WebAssembly] Stop unrolling SIMD shifts since they are fixed in V8 (authored by tlively, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D66166?vs=214914&id=215140#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66166/new/

https://reviews.llvm.org/D66166

Files:
  llvm/trunk/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp


Index: llvm/trunk/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
===================================================================
--- llvm/trunk/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
+++ llvm/trunk/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
@@ -1449,11 +1449,6 @@
   // Only manually lower vector shifts
   assert(Op.getSimpleValueType().isVector());
 
-  // Expand all vector shifts until V8 fixes its implementation
-  // TODO: remove this once V8 is fixed
-  if (!Subtarget->hasUnimplementedSIMD128())
-    return unrollVectorShift(Op, DAG);
-
   // Unroll non-splat vector shifts
   BuildVectorSDNode *ShiftVec;
   SDValue SplatVal;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66166.215140.patch
Type: text/x-patch
Size: 665 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190814/cfc1ca4c/attachment.bin>