[PATCH] D66197: AMDGPU: Add intrinsics for address space identification

Brian Sumner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 14 09:07:24 PDT 2019


b-sumner added a comment.

In D66197#1629436 <https://reviews.llvm.org/D66197#1629436>, @arsenm wrote:

> In D66197#1629348 <https://reviews.llvm.org/D66197#1629348>, @b-sumner wrote:
>
> > Looks fine to me.  Thanks!
>
>
> I wonder if is.local should be is.shared because that's what getreg calls this


That would probably be better.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66197/new/

https://reviews.llvm.org/D66197





More information about the llvm-commits mailing list