[PATCH] D66063: [Object] Create MutableELFObject Class for Doing Mutations on ELFObjectFiles [Part 5]

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 14 08:44:27 PDT 2019


jhenderson added a comment.

I think you need to be careful that you any methods in ELFObjectFile etc that query the header return the updated value. For example, I see there's a `getStartAddress` function, which returns the value of e_entry. If you change e_entry, you'll want this to return the updated value, I think.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66063/new/

https://reviews.llvm.org/D66063





More information about the llvm-commits mailing list